deactivate signal in the context of imports

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

product_portfolio/importers.py

@@ -20,6 +20,8 @@
 from django.db import transaction
 from django.db.models import ObjectDoesNotExist
 from django.db.models import Q
+from django.db.models.signals import post_delete
+from django.db.models.signals import post_save
 from django.utils.translation import gettext_lazy as _
 
 from license_expression import Licensing
@@ -40,6 +42,8 @@
 from dje.models import Dataspace
 from dje.utils import get_help_text
 from dje.utils import is_uuid4
+from policy.signals import evaluate_product_rules_on_productpackage_change
+from policy.tasks import evaluate_product_rules_task
 from product_portfolio.forms import ProductComponentLicenseExpressionFormMixin
 from product_portfolio.models import CodebaseResource
 from product_portfolio.models import CodebaseResourceUsage
@@ -50,6 +54,8 @@
 from product_portfolio.models import ProductPackage
 from product_portfolio.models import ProductRelationStatus
 from product_portfolio.models import ScanCodeProject
+from vulnerabilities.triage.signals import reevaluate_on_product_package_change
+from vulnerabilities.triage.tasks import reevaluate_product_triage_rulesets_task
 
 logger = logging.getLogger(__name__)
 
@@ -62,6 +68,35 @@ def log_elapsed(label):
     logger.info(f"{label}: {time.perf_counter() - start:.1f}s")
 
 
+@contextmanager
+def paused_product_package_reevaluation():
+    """
+    Pause the policy and triage re-evaluation signals triggered by ProductPackage changes,
+    for the duration of a bulk import. Call `reevaluate_products()` once the import completes
+    to evaluate each affected product exactly once, instead of once per imported row.
+    """
+    receivers = [
+        evaluate_product_rules_on_productpackage_change,
+        reevaluate_on_product_package_change,
+    ]
+    for receiver in receivers:
+        post_save.disconnect(receiver, sender=ProductPackage)
+        post_delete.disconnect(receiver, sender=ProductPackage)
+    try:
+        yield
+    finally:
+        for receiver in receivers:
+            post_save.connect(receiver, sender=ProductPackage)
+            post_delete.connect(receiver, sender=ProductPackage)
+
+
+def reevaluate_products(products):
+    """Queue the policy and triage re-evaluation once for each of the given products."""
+    for product in products:
+        evaluate_product_rules_task.delay(product_uuid=product.uuid)
+        reevaluate_product_triage_rulesets_task.delay(product_uuid=product.uuid)
+
+
 class CleanProductMixin(ComponentRelatedFieldImportMixin):
     def clean_product(self):
         queryset = Product.objects.get_queryset(self.user)
@@ -230,6 +265,14 @@ def clean_package(self):
 class ProductPackageImporter(BaseImporter):
     model_form = ProductPackageImportForm
 
+    def save_all(self):
+        with paused_product_package_reevaluation():
+            super().save_all()
+
+        touched_product_packages = self.results["added"] + self.results["modified"]
+        products = {product_package.product for product_package in touched_product_packages}
+        reevaluate_products(products)
+
 
 class CodebaseResourceImportForm(CleanProductMixin, BaseImportModelForm):
     product = forms.CharField(
@@ -434,7 +477,9 @@ def save(self):
         self.create_scancode_project()
         self.load_data_from_file()
         self.validate_headers()
-        self.import_packages()
+        with paused_product_package_reevaluation():
+            self.import_packages()
+        reevaluate_products([self.product])
         if self.create_codebase_resources:
             self.import_codebase_resources()
         self.update_scancode_project()
@@ -720,7 +765,9 @@ def save(self):
                 self.dependencies = scancodeio.fetch_project_dependencies(self.project_uuid)
 
         with log_elapsed("import_packages"):
-            self.import_packages()
+            with paused_product_package_reevaluation():
+                self.import_packages()
+        reevaluate_products([self.product])
 
         if self.create_dependencies:
             with log_elapsed("import_dependencies"):

vulnerabilities/triage/signals.py

@@ -49,7 +49,7 @@ def reevaluate_on_analysis_change(sender, instance, **kwargs):
     """Re-evaluate triage on a product when an vulnerability analysis is updated."""
     signal = kwargs.get("signal")
     if signal == post_save and instance.applied_by_preset_id:
-          # When the analysis is created by the triage engine itself, the evaluation is skipped.
+        # When the analysis is created by the triage engine itself, the evaluation is skipped.
         return
 
     # When a user explicitly deletes their analysis, skip preset application to avoid

vulnerabilities/triage/tasks.py

@@ -8,14 +8,36 @@
 
 import logging
 
+from django.apps import apps
+
 from django_rq import job
 
+from dje.models import get_unsecured_manager
 from vulnerabilities.triage.engine import evaluate_ruleset
+from vulnerabilities.triage.engine import reevaluate_product_rulesets
 from vulnerabilities.triage.models import ProductTriageRuleset
 
 logger = logging.getLogger(__name__)
 
 
+@job
+def reevaluate_product_triage_rulesets_task(product_uuid):
+    """Re-evaluate all enabled triage rulesets assigned to the given product."""
+    Product = apps.get_model("product_portfolio", "product")
+
+    try:
+        product = get_unsecured_manager(Product).get(uuid=product_uuid)
+    except Product.DoesNotExist:
+        logger.error(
+            f"reevaluate_product_triage_rulesets_task: product {product_uuid} not found,"
+            " skipping."
+        )
+        return
+
+    logger.info(f"Evaluating triage rulesets for product {product}")
+    reevaluate_product_rulesets(product)
+
+
 @job
 def evaluate_all_products_vulnerability_triage_task():
     """Evaluate all enabled triage rulesets against their assigned products."""