rename action as recommended_action

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

product_portfolio/filters.py

@@ -467,7 +467,7 @@ def filter_triage_action(queryset, name, value):
             vulnerability__affected_packages__productpackages=OuterRef("pk"),
             ruleset__enabled=True,
             ruleset_id=Subquery(winning_ruleset_id),
-            action=value,
+            recommended_action=value,
         )
         return queryset.filter(Exists(primary_triage)).distinct()
 

product_portfolio/templates/product_portfolio/modals/manage_triage_rulesets_form.html

@@ -33,7 +33,7 @@
                 {% endfor %}
               </span>
             {% endif %}
-            {% if ruleset.action %}
+            {% if ruleset.recommended_action %}
               <span class="d-flex align-items-center gap-2 mt-1">
                 <span class="small text-body-secondary">{% trans "Recommended action:" %}</span>
                 <span class="badge {{ ruleset.action_badge_class }} text-nowrap">

product_portfolio/templates/product_portfolio/tabs/tab_packages_vulnerabilities.html

@@ -78,7 +78,7 @@
             <td>
               {% if vulnerability.triage_record %}
                 {% with record=vulnerability.triage_record %}
-                  {% if record.action %}
+                  {% if record.recommended_action %}
                     <span class="badge {{ record.action_badge_class }} d-block text-start">
                       <i class="fas {{ record.action_icon }} me-1"></i>{{ record.action_label }}
                     </span>

product_portfolio/tests/test_filters.py

@@ -206,7 +206,7 @@ def setUp(self):
         )
         ruleset = TriageRuleset.objects.create(
             name="Upgrade Ruleset",
-            action=TriageAction.UPGRADE,
+            recommended_action=TriageAction.UPGRADE,
             precedence=100,
             dataspace=self.dataspace,
             rules_config={"risk_score": {"is_active": True, "min_risk_score": 8.0}},

product_portfolio/tests/test_views.py

@@ -306,7 +306,7 @@ def test_product_portfolio_tab_vulnerability_view_filters(self):
         # product has at least one enabled TriageRuleset assigned to it.
         ruleset = TriageRuleset.objects.create(
             name="Upgrade Ruleset",
-            action=TriageAction.UPGRADE,
+            recommended_action=TriageAction.UPGRADE,
             precedence=100,
             dataspace=self.dataspace,
         )
@@ -4361,7 +4361,7 @@ def setUp(self):
         )
         self.ruleset = TriageRuleset.objects.create(
             name="Upgrade Ruleset",
-            action=TriageAction.UPGRADE,
+            recommended_action=TriageAction.UPGRADE,
             precedence=100,
             dataspace=self.dataspace,
         )

product_portfolio/views.py

@@ -1349,8 +1349,12 @@ def attach_triage_data(self, product, page_obj):
             .select_related("ruleset", "request")
         )
         for record in triage_records:
-            record.action_label = action_labels.get(record.action, record.action)
-            badge_class, icon = TRIAGE_ACTION_STYLES.get(record.action, TRIAGE_ACTION_DEFAULT_STYLE)
+            record.action_label = action_labels.get(
+                record.recommended_action, record.recommended_action
+            )
+            badge_class, icon = TRIAGE_ACTION_STYLES.get(
+                record.recommended_action, TRIAGE_ACTION_DEFAULT_STYLE
+            )
             record.action_badge_class = badge_class
             record.action_icon = icon
 
@@ -2251,9 +2255,11 @@ def manage_triage_rulesets_view(request, dataspace, name, version=""):
     action_labels = dict(TriageAction.choices)
 
     for ruleset in available_rulesets:
-        ruleset.action_label = action_labels.get(ruleset.action, ruleset.action)
+        ruleset.action_label = action_labels.get(
+            ruleset.recommended_action, ruleset.recommended_action
+        )
         action_badge_class, action_icon = TRIAGE_ACTION_STYLES.get(
-            ruleset.action, TRIAGE_ACTION_DEFAULT_STYLE
+            ruleset.recommended_action, TRIAGE_ACTION_DEFAULT_STYLE
         )
         ruleset.action_badge_class = action_badge_class
         ruleset.action_icon = action_icon

vulnerabilities/migrations/0011_vulnerabilityanalysis_applied_by_preset.py

@@ -1,4 +1,4 @@
-# Generated by Django 6.0.6 on 2026-08-12 06:37
+# Generated by Django 6.0.6 on 2026-08-14 15:02
 
 import django.db.models.deletion
 from django.db import migrations, models
@@ -8,7 +8,7 @@ class Migration(migrations.Migration):
 
     dependencies = [
         ('vulnerabilities', '0010_api_v3_remove_old_fields'),
-        ('vulnerabilities_triage', '0002_analysispreset_triageruleset_analysis_preset'),
+        ('vulnerabilities_triage', '0001_initial'),
     ]
 
     operations = [

vulnerabilities/triage/admin.py

@@ -101,7 +101,7 @@ class TriageRulesetAdmin(DataspacedAdmin):
 
     @admin.display(description="Action")
     def get_action_label(self, obj):
-        return dict(TriageAction.choices).get(obj.action, obj.action)
+        return dict(TriageAction.choices).get(obj.recommended_action, obj.recommended_action)
 
     @admin.display(description="Enabled rules")
     def get_enabled_rules(self, obj):
@@ -134,7 +134,7 @@ def get_form(self, request, obj=None, change=False, **kwargs):
         kwargs["fields"] = [
             "name",
             "description",
-            "action",
+            "recommended_action",
             "precedence",
             "enabled",
             "analysis_preset",
@@ -150,7 +150,7 @@ def get_fieldsets(self, request, obj=None):
                     "fields": [
                         "name",
                         "description",
-                        "action",
+                        "recommended_action",
                         "precedence",
                         "enabled",
                         "analysis_preset",

vulnerabilities/triage/engine.py

@@ -147,7 +147,7 @@ def sync_triage_records(ruleset, product, matched_rules_per_vulnerability_id, ap
             vulnerability_id=vulnerability_id,
             product=product,
             ruleset=ruleset,
-            action=ruleset.action,
+            recommended_action=ruleset.recommended_action,
             matched_rules=matched_rules,
             dataspace=ruleset.dataspace,
             detected_date=now,
@@ -159,7 +159,7 @@ def sync_triage_records(ruleset, product, matched_rules_per_vulnerability_id, ap
         records,
         update_conflicts=True,
         unique_fields=["vulnerability", "product", "ruleset"],
-        update_fields=["action", "matched_rules", "last_checked", "dataspace"],
+        update_fields=["recommended_action", "matched_rules", "last_checked", "dataspace"],
     )
 
     stale_records_qs = TriageRecord.objects.filter(

vulnerabilities/triage/forms.py

@@ -37,7 +37,7 @@ class Meta:
 
 
 class TriageRulesetForm(DataspacedAdminForm):
-    action = forms.ChoiceField(
+    recommended_action = forms.ChoiceField(
         choices=[("", "---------")] + list(TriageAction.choices),
         required=False,
     )
@@ -47,7 +47,7 @@ class Meta:
         fields = [
             "name",
             "description",
-            "action",
+            "recommended_action",
             "precedence",
             "enabled",
             "analysis_preset",