plug signals to evaluate rules

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

policy/signals.py

@@ -8,16 +8,37 @@
 
 import logging
 
+from django.db.models.signals import post_delete
 from django.db.models.signals import post_save
 from django.dispatch import receiver
 
+from policy.tasks import evaluate_all_products_rules_task
 from policy.tasks import evaluate_product_rules_task
 
 logger = logging.getLogger(__name__)
 
 
 @receiver(post_save, sender="product_portfolio.Product")
-def evaluate_product_rules_on_save(sender, instance, **kwargs):
+def evaluate_product_rules_on_product_save(sender, instance, **kwargs):
     """Queue a policy rule evaluation whenever a product is saved."""
-    logger.debug(f"Queuing policy rule evaluation for product {instance.uuid}")
     evaluate_product_rules_task.delay(product_uuid=instance.uuid)
+
+
+@receiver(post_save, sender="product_portfolio.ProductPackage")
+def evaluate_product_rules_on_productpackage_save(sender, instance, **kwargs):
+    """Queue a policy rule evaluation whenever a package is added or updated in a product."""
+    evaluate_product_rules_task.delay(product_uuid=instance.product.uuid)
+
+
+@receiver(post_delete, sender="product_portfolio.ProductPackage")
+def evaluate_product_rules_on_productpackage_delete(sender, instance, **kwargs):
+    """Queue a policy rule evaluation whenever a package is removed from a product."""
+    evaluate_product_rules_task.delay(product_uuid=instance.product.uuid)
+
+
+@receiver(post_save, sender="component_catalog.Package")
+def evaluate_product_rules_on_package_save(sender, instance, **kwargs):
+    """Queue a policy rule evaluation for all products containing this package."""
+    product_uuids = list(instance.productpackages.values_list("product__uuid", flat=True))
+    if product_uuids:
+        evaluate_all_products_rules_task.delay(product_uuids=product_uuids)

policy/tasks.py

@@ -59,12 +59,17 @@ def evaluate_product_rules_task(product_uuid):
 
 
 @job
-def evaluate_all_products_rules_task(include_locked=False):
-    """Evaluate policy rules for every product directly, skipping locked ones by default."""
+def evaluate_all_products_rules_task(include_locked=False, product_uuids=None):
+    """
+    Evaluate policy rules for products, skipping locked ones by default.
+    When product_uuids is provided, only those products are evaluated.
+    """
     Product = apps.get_model("product_portfolio", "product")
 
     products = get_unsecured_manager(Product).select_related("dataspace")
-    if not include_locked:
+    if product_uuids is not None:
+        products = products.filter(uuid__in=product_uuids)
+    elif not include_locked:
         products = products.exclude_locked()
 
     count = products.count()

product_portfolio/models.py

@@ -442,10 +442,6 @@ def save(self, *args, **kwargs):
         if self.has_changed("configuration_status_id"):
             self.actions_on_status_change()
 
-        from policy.engine import evaluate_rules
-
-        evaluate_rules(product=self)
-
     def get_attribution_url(self):
         return self.get_url("attribution")
 

product_portfolio/views.py

@@ -112,6 +112,9 @@
 from license_library.filters import LicenseFilterSet
 from license_library.models import License
 from license_library.models import LicenseAssignedTag
+from policy.engine import evaluate_rules
+from policy.engine import get_effective_config
+from policy.rules import RULE_REGISTRY
 from product_portfolio.filters import CodebaseResourceFilterSet
 from product_portfolio.filters import DependencyFilterSet
 from product_portfolio.filters import ProductComponentFilterSet
@@ -143,9 +146,6 @@
 from product_portfolio.models import ScanCodeProject
 from product_portfolio.tasks import improve_packages_from_purldb_task
 from product_portfolio.tasks import pull_project_data_from_scancodeio_task
-from policy.engine import evaluate_rules
-from policy.engine import get_effective_config
-from policy.rules import RULE_REGISTRY
 from vulnerabilities.forms import VulnerabilityAnalysisForm
 from vulnerabilities.models import AffectedByVulnerabilityMixin
 from vulnerabilities.models import Vulnerability