handle the validation error in admin

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

vulnerabilities/triage/forms.py

@@ -7,6 +7,7 @@
 #
 
 from django import forms
+from django.core.exceptions import ValidationError
 
 from dje.forms import DataspacedAdminForm
 from vulnerabilities.models import VulnerabilityAnalysisContentMixin
@@ -35,6 +36,13 @@ class Meta:
             "is_reachable",
         ]
 
+    def clean(self):
+        main_fields = ["state", "justification", "responses", "detail"]
+        if not any(self.cleaned_data.get(field_name) for field_name in main_fields):
+            raise ValidationError(
+                "At least one of state, justification, responses or detail must be provided."
+            )
+
 
 class TriageRulesetForm(DataspacedAdminForm):
     recommended_action = forms.ChoiceField(

vulnerabilities/triage/tests/test_forms.py

@@ -9,10 +9,33 @@
 from django.test import TestCase
 
 from dje.models import Dataspace
+from vulnerabilities.triage.forms import AnalysisPresetForm
 from vulnerabilities.triage.forms import TriageRulesetForm
+from vulnerabilities.triage.models import AnalysisPreset
 from vulnerabilities.triage.models import TriageRuleset
 
 
+class AnalysisPresetFormTestCase(TestCase):
+    def setUp(self):
+        self.dataspace = Dataspace.objects.create(name="nexB")
+
+    def test_rejects_a_preset_with_no_content_field_set(self):
+        # Mirrors VulnerabilityAnalysisForm.clean: is_reachable alone is not enough content
+        # to apply, and must be caught here rather than crash in AnalysisPreset.save().
+        data = {"name": "No content", "is_reachable": True}
+        form = AnalysisPresetForm(data=data, instance=AnalysisPreset(dataspace=self.dataspace))
+        self.assertFalse(form.is_valid())
+        msg = "At least one of state, justification, responses or detail must be provided."
+        self.assertEqual({"__all__": [msg]}, form.errors)
+
+    def test_accepts_a_preset_with_detail_only(self):
+        data = {"name": "Detail only", "detail": "Some detail"}
+        form = AnalysisPresetForm(data=data, instance=AnalysisPreset(dataspace=self.dataspace))
+        self.assertTrue(form.is_valid(), form.errors)
+        preset = form.save()
+        self.assertEqual("Some detail", preset.detail)
+
+
 class TriageRulesetFormTestCase(TestCase):
     def setUp(self):
         self.dataspace = Dataspace.objects.create(name="nexB")