Skip to content

Added the scaned options for the old and the new files - #145

Closed
pratik0316 wants to merge 3 commits into
aboutcode-org:developfrom
pratik0316:addingTheScanOptionsInNewAndOldFile
Closed

pratik0316 wants to merge 3 commits into
aboutcode-org:developfrom
pratik0316:addingTheScanOptionsInNewAndOldFile

Conversation

@pratik0316

Copy link
Copy Markdown
Collaborator

In this PR I have added a method to add the scanned options in the new and old file, These options will be available shown in the json file of the deltacode json file output.
The new json file will now contain an additional field of scanned_options in it.
Screenshot from 2020-03-19 11-01-28
So this is my new json file output containing the scanned options present in the new and old file scans
This PR is addressed to the issue of #2

Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
@pratik0316
pratik0316 force-pushed the addingTheScanOptionsInNewAndOldFile branch from 9abfcb4 to 16ad933 Compare March 19, 2020 05:35
@pratik0316

pratik0316 commented Mar 19, 2020

Copy link
Copy Markdown
Collaborator Author

@MaJuRG I have inserted scanned options for new and old file in the deltacode output ,I have not modified the test case so due to this some of the test cases(3 test cases in both windows and osx build ) are not successful as the expected and the actual results in the output are different to some extent(regarding the output in the json file) .Sir if you would kindly review this PR and suggest changes, I would be modifying the test cases too.

…lta json output scan

Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
@pratik0316
pratik0316 force-pushed the addingTheScanOptionsInNewAndOldFile branch from ae8e59f to 8d181b2 Compare March 19, 2020 15:10

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to a ticket at all? I am not sure we want this...

@pratik0316

Copy link
Copy Markdown
Collaborator Author

Thanks sir for the review.
Sir I think the issue of #2 is related to it.

@pratik0316

Copy link
Copy Markdown
Collaborator Author

In this Pr my two cases are failing in both Linux and osx build out of 155 test cases

@steven-esser

Copy link
Copy Markdown
Contributor

@Pratikrocks You will need to regen those two particular test files since you have added some additional output

@pratik0316

Copy link
Copy Markdown
Collaborator Author

okay @MaJuRG I am trying to sort it out

@pratik0316

Copy link
Copy Markdown
Collaborator Author

Actually the error is generated due to mismatch in the in the result file
expected_file = '/home/travis/build/nexB/deltacode/tests/data/deltacode/sugar-expected.json' result_file = '/home/travis/build/nexB/deltacode/lib/python2.7/tmp/scancode-tk-tests -29D3x6/1j9Ryh/td/tf.json'
This file is generated in the server side during its configuration(as it is present in the lib directory).
How can we change this file

@steven-esser

Copy link
Copy Markdown
Contributor

The test files on Travis are taken from the ones in the codebase.

@steven-esser

Copy link
Copy Markdown
Contributor

Closing due to stagnation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants