Improve version range resolution - #183
Merged
Merged
Conversation
- issue aboutcode-org/univers#118 Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
JonoYang
requested changes
Sep 7, 2023
JonoYang
left a comment
JonoYang
left a comment
Member
There was a problem hiding this comment.
@keshav-space I have some questions about the try-except blocks you've added.
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Jono Yang <jyang@nexb.com>
Member
|
@keshav-space Thanks for the univers update! I've regenerated a test file, so we can pass all the tests. Merging. |
JonoYang
added a commit
that referenced
this pull request
Apr 14, 2025
Improve version range resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invalid constraints sequenceexception while testing whether a given version is present in givenversexpressionon_demand_queueonly supportsmavenandnpm