Skip to content

Commit eaa34b1

Browse files
committed
Add todos for problematic handling of many packages
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
1 parent aae16a4 commit eaa34b1

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

src/packagedcode/models.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,6 +1022,9 @@ def assemble_from_many(cls, pkgdata_resources, codebase,):
10221022
resource.for_packages.append(package_uid)
10231023
resource.save(codebase)
10241024
else:
1025+
# FIXME: What is the package_data is NOT for the same package as package?
1026+
# FIXME: What if the update did not do anything? (it does return True or False)
1027+
# FIXME: There we would be missing out packges AND/OR errors
10251028
package.update(
10261029
package_data=package_data,
10271030
datafile_path=resource.path,

0 commit comments

Comments
 (0)