Remove duplicate tests

Add unit tests for each kind

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

src/univers/version_constraint.py

@@ -132,6 +132,28 @@ def __lt__(self, other):
         # we compare tuples, version first
         return (self.version, self.comparator).__lt__((other.version, other.comparator))
 
+    def is_star(self):
+        return self.comparator == "*"
+
+    def invert(self):
+        INVERTED_COMPARATORS = {
+            ">=": "<",
+            "<=": ">",
+            "!=": "=",
+            "<": ">=",
+            ">": "<=",
+            "=": "!=",
+        }
+
+        if self.is_star():
+            return None
+
+        inverted_comparator = INVERTED_COMPARATORS[self.comparator]
+        return self.__class__(
+            comparator=inverted_comparator,
+            version=self.version,
+        )
+
     @classmethod
     def from_string(cls, string, version_class):
         """

src/univers/version_range.py

@@ -174,31 +174,25 @@ def from_versions(cls, sequence):
             constraints.append(constraint)
         return cls(constraints=constraints)
 
+    def is_star(self):
+        return len(self.constraints) == 1 and self.constraints[0].is_star()
+
     def invert(self):
         """
-        Return the inverse of this VersionRange. For example, if this range is
+        Return the inverse or complement of this VersionRange. For example, if this range is
         ">=1.0.0", the inverse is "<1.0.0".
-        >>> VersionRange.from_string("vers:npm/>=1.0.0").invert()
-        NpmVersionRange(constraints=(VersionConstraint(comparator='<', version=SemverVersion(string='1.0.0')),))
+        >>> str(VersionRange.from_string("vers:npm/>=1.0.0").invert())
+        'vers:npm/<1.0.0'
         """
         inverted_constraints = []
 
-        if len(self.constraints) == 1 and self.constraints[0].comparator == "*":
+        if self.is_star():
             # The inverse of "*" is an empty range.
             return None
 
         for constraint in self.constraints:
-            if constraint.comparator in INVERTED_COMPARATORS:
-                inverted_comparator = INVERTED_COMPARATORS[constraint.comparator]
-            else:
-                raise NotImplementedError(
-                    f"Cannot invert a range with a {constraint.comparator!r} comparator."
-                )
-            inverted_constraint = VersionConstraint(
-                comparator=inverted_comparator,
-                version=constraint.version,
-            )
-            inverted_constraints.append(inverted_constraint)
+            inverted_constraints.append(constraint.invert())
+
         return self.__class__(constraints=inverted_constraints)
 
     def __str__(self):

tests/test_version_range.py

@@ -395,11 +395,18 @@ def test_npm_advisory_version_range_parse(test_case):
     assert str(result) == test_case["expected_vers"]
 
 
-@pytest.mark.parametrize("test_case", json.load(open("./tests/data/inverse-data.json")))
-def test_inverse(test_case):
-    result = NpmVersionRange.from_string(test_case["original"])
-    if test_case["inverted"]:
-        inverted = NpmVersionRange.from_string(test_case["inverted"])
-        assert result.invert() == inverted
-    else:
-        assert result.invert() is None
+def test_inverse():
+    vers_with_equal_operator = VersionRange.from_string("vers:gem/1.0")
+    assert str(vers_with_equal_operator.invert()) == "vers:gem/!=1.0"
+    assert VersionRange.from_string("vers:gem/!=1.0").invert() == vers_with_equal_operator
+
+    vers_with_less_than_operator = VersionRange.from_string("vers:gem/<1.0")
+    assert str(vers_with_less_than_operator.invert()) == "vers:gem/>=1.0"
+    assert VersionRange.from_string("vers:gem/>=1.0").invert() == vers_with_less_than_operator
+
+    vers_with_greater_than_operator = VersionRange.from_string("vers:gem/>1.0")
+    assert str(vers_with_greater_than_operator.invert()) == "vers:gem/<=1.0"
+    assert VersionRange.from_string("vers:gem/<=1.0").invert() == vers_with_greater_than_operator
+
+    vers_with_complex_constraints = VersionRange.from_string("vers:gem/<=1.0|>=3.0|<4.0|!=5.0")
+    assert str(vers_with_complex_constraints.invert()) == "vers:gem/>1.0|<3.0|>=4.0|5.0"