Skip to content

Commit f950cac

Browse files
authored
Merge pull request #197 from aboutcode-org/191-fix-alpine-scheme
fix: use apk scheme for Alpine packages
2 parents 968d66f + 8a26f05 commit f950cac

4 files changed

Lines changed: 11 additions & 3 deletions

File tree

src/univers/version_constraint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ def split(string):
225225
# "<<2.3" and ">>2.3" in VERS constraints which are explicitly not supported in VERS.
226226
elif version and version[0] in "<>!=*":
227227
raise ValueError(f"Unknown comparator in constraint: {constraint_string!r}")
228-
228+
229229
return comparator, version
230230

231231
# default to equality

src/univers/version_range.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1016,7 +1016,7 @@ class EbuildVersionRange(VersionRange):
10161016

10171017

10181018
class AlpineLinuxVersionRange(VersionRange):
1019-
scheme = "alpine"
1019+
scheme = "apk"
10201020
version_class = versions.AlpineLinuxVersion
10211021

10221022

tests/test_version_constraint.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,11 @@ def test_invert_opertaion(original, inverted):
8888
else:
8989
assert constraint.invert() is None
9090

91+
9192
@pytest.mark.parametrize("spec", ["<<2.3", ">>2.3"])
9293
def test_invalid_vers_comparator_prefixes(spec):
9394
with pytest.raises(ValueError, match="Unknown comparator"):
9495
VersionConstraint.from_string(
9596
string=spec,
9697
version_class=versions.SemverVersion,
97-
)
98+
)

tests/test_version_range.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,13 @@ def test_AlpineLinuxVersionRange_from_versions():
220220
assert version_range == expected
221221

222222

223+
def test_AlpineLinuxVersionRange_has_apk_scheme():
224+
sequence = ["3.18.0", "2.14.9-r1", "3.0.0"]
225+
expected = "vers:apk/2.14.9-r1|3.0.0|3.18.0"
226+
version_range = AlpineLinuxVersionRange.from_versions(sequence).to_string()
227+
assert version_range == expected
228+
229+
223230
def test_VersionRange_from_versions_with_empty_constraints():
224231
sequence = []
225232
expected = None

0 commit comments

Comments
 (0)