Skip to content

Univers decides to explode when truth is violated #25

Description

@Hritik14
>>> from univers.version_range import NginxVersionRange
>>> rng = NginxVersionRange.from_string('vers:nginx/>=1.9.5|<=1.17.2')
>>> SemverVersion("1.9.8") in rng
True
>>> SemverVersion("1.9.5") in rng
True
>>> SemverVersion("1.9.4") in rng
---------------------------------------------------------------------------
Exception                                 Traceback (most recent call last)
<ipython-input-92-15259a3594cd> in <module>
----> 1 SemverVersion("1.9.4") in rng

~/Contrib/univers/src/univers/version_range.py in __contains__(self, version)
    159                 f"{version!r} is not of expected type: {self.version_class!r}",
    160             )
--> 161         return contains_version(version, self.constraints)
    162
    163     contains = __contains__

~/Contrib/univers/src/univers/version_constraint.py in contains_version(version, constraints)
    503         else:
    504             # this should never happen as the constraints must be valid going in
--> 505             raise Exception(f"Invalid constraints sequence: {constraints }")
    506
    507     # If this is the last iteration and next comparator is ">" or >="

Exception: Invalid constraints sequence: [VersionConstraint(comparator='>=', version=SemverVersion(string='1.9.5')), VersionConstraint(comparator='<=', version=SemverVersion(string='1.17.2'))]

Last statement should have just returned False

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions