Add Nuget Version support in Univers - #60
Merged
Merged
Conversation
Contributor
Author
|
TODO: |
TG1999
force-pushed
the
nuget_version_range
branch
2 times, most recently
from
April 13, 2022 12:16
cf82f9a to
3e89f8c
Compare
pombredanne
requested changes
Apr 13, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks! ... here are some nits for your consideration!
TG1999
force-pushed
the
nuget_version_range
branch
from
April 13, 2022 18:40
3e89f8c to
6d9badc
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
nuget_version_range
branch
from
April 13, 2022 18:47
6d9badc to
725797c
Compare
pombredanne
reviewed
Apr 15, 2022
| @@ -0,0 +1,77 @@ | |||
| # Copyright 2022 Google LLC | |||
| # | |||
Member
There was a problem hiding this comment.
Adding the missing copyright from upstream https://github.com/NuGet/NuGet.Client/blob/eea4636696cc7b6a3e682797c3dd717ad25fd7c9/test/NuGet.Core.Tests/NuGet.Versioning.Test/VersionComparerTests.cs
Suggested change
| # | |
| # Copyright (c) .NET Foundation. All rights reserved. |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
pushed a commit
to TG1999/univers
that referenced
this pull request
May 10, 2022
Update signoff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com