Add Nuget versions tests - #70
Merged
Merged
Conversation
Conflicts: .gitignore NuGet.Config README.md build/build.msbuild build/test.targets global.json tools/sign-check.ps1
Conflicts: .gitignore NuGet.Config NuGet3.sln README.md build/build.msbuild build/test.targets global.json tools/sign-check.ps1
Conflicts: .gitignore NuGet.Config build/build.msbuild global.json makefile.shade
* Make VersionRange.TryParse handle single-number version spec
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is partial and a work in progress Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Still a work in progress Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We do not support them Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This does not make sense in our context Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
TG1999
reviewed
May 12, 2022
TG1999
approved these changes
May 12, 2022
TG1999
left a comment
TG1999
left a comment
Contributor
There was a problem hiding this comment.
LGTM! A small nitpick for your consideration
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds several tests pulled from the NuGet client git repo and ported from C# to Python. Several of these are not yet fully working and are marked as skipped or expected failures.