retire license category reporting - #116
Closed
iamsid2 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: iamsid2 <shaktimund97@gmail.com>
steven-esser
suggested changes
Mar 29, 2019
steven-esser
left a comment
steven-esser
left a comment
Contributor
There was a problem hiding this comment.
You have a number of failing tests. Please fix these.
You can run the test suite locally via py.test.
| new_categories = set(license.category for license in new_licenses) | ||
| old_categories = set(license.category for license in old_licenses) | ||
| # new_categories = set(license.category for license in new_licenses) | ||
| # old_categories = set(license.category for license in old_licenses) |
Contributor
There was a problem hiding this comment.
Delete these lines instead of adding comments
| # delta.update(20, category.lower() + ' added') | ||
| # # no license ==> 'Permissive' or 'Public Domain' | ||
| # else: | ||
| # delta.update(0, category.lower() + ' added') |
Contributor
There was a problem hiding this comment.
Same thing here, see above comments
| # delta.update(10, category.lower() + ' added') | ||
| # # 'Permissive' or 'Public Domain' ==> 'Permissive' or 'Public Domain' if not in old_categories | ||
| # elif category not in unique_categories: | ||
| # delta.update(0, category.lower() + ' added') |
Contributor
There was a problem hiding this comment.
Same comment as above
Author
|
yeah working on it now. |
Author
|
Looks like there is a clash between python 3.6 and 2.7 as i have anaconda installed which as python 3.6 as its root |
Contributor
|
@iamsid2 Currently, DeltaCode uses python2.7. If you install python2.7, it can exist alongside python36 and our configure scripts will be smart enough to use the correct python version. |
Contributor
|
Closing due to stagnation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to solve issue106
Signed-off-by: iamsid2 shaktimund97@gmail.com