Skip to content

Add limited delta stats after running - #132

Closed
dimitraka wants to merge 2 commits into
aboutcode-org:developfrom
dimitraka:130-add-limited-delta-stats-after-running
Closed

Add limited delta stats after running#132
dimitraka wants to merge 2 commits into
aboutcode-org:developfrom
dimitraka:130-add-limited-delta-stats-after-running

Conversation

@dimitraka

Copy link
Copy Markdown

Signed-off-by: Dimitra Karatza kadimitra@ece.auth.gr

Signed-off-by: kadimitra <kadimitra@ece.auth.gr>
Comment thread src/deltacode/cli.py Outdated
click.echo('DeltaCode version ' + __version__)
ctx.exit()

def print_summary(new,old,deltas_count):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space after the comma for each of these args

Comment thread src/deltacode/cli.py
write_json(deltacode, json_file, all_delta_types)

# show limited delta status
deltas_count = len([d for d in deltas(deltacode, all_delta_types)])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see the counts of each particular Delta type, not the total number of deltas.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you would like to see the counts of each type of "factor" for each delta? That is to say factors can be for example "added", "license info added", "moved" etc. and you would like to see the counts of these such factors, lets say we have 5 "added", 3 "moved" etc.

@steven-esser steven-esser Mar 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I should have clarified that :)

You can treat Deltas with multiple factors as their own entity for the sake of the counts

Also, I would be curious to known the performance implications of generating these counts is. We may want to add this feature as a runtime option if it takes a long time on large datasets.

Signed-off-by: kadimitra <kadimitra@ece.auth.gr>
@dimitraka
dimitraka force-pushed the 130-add-limited-delta-stats-after-running branch from b46f362 to 92548c4 Compare March 16, 2020 15:52
@steven-esser

Copy link
Copy Markdown
Contributor

Closing due to stagnation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants