Added limited delta status at cli - #135
Conversation
| outfile.write('\n') | ||
| # Output delta_stats at cli | ||
| status=deltacode.stats.to_dict() | ||
| click.echo("\nDelta stats .....\n") |
There was a problem hiding this comment.
I would change .... to :
| status=deltacode.stats.to_dict() | ||
| click.echo("\nDelta stats .....\n") | ||
| for stat, value in status.iteritems(): | ||
| click.echo(str(stat) + " : " + str(value)) |
There was a problem hiding this comment.
Do we really need to cast as str here?
|
|
steven-esser
left a comment
steven-esser
left a comment
There was a problem hiding this comment.
See inline comments.
Also, you should improve your commit messages. A commit message of "Updates" tells me nothing of what has been done. See: https://chris.beams.io/posts/git-commit/
Please rebase your "updates" commits into a single commit and update the commit message to something more detailed using the link above.
| click.echo("\nDelta stats :\n") | ||
| for stat, value in status.iteritems(): | ||
| click.echo("{} : {}".format(stat,value)) | ||
| #click.echo("\n") |
There was a problem hiding this comment.
Get rid of this commented out line if it is not needed.
| simplejson.dump(results, outfile, iterable_as_array=True, indent=2) | ||
| outfile.write('\n') | ||
| # Output delta_stats at cli | ||
| status=deltacode.stats.to_dict() |
There was a problem hiding this comment.
Variable assignments should be separated by spaces.
Signed-off-by: ankit2001 <ankitchoudhary202.ac@gmail.com>
|
I have rebased it into single commit , |
2 participants
This pr is meant to solve issue #130
please review ir @MaJuRG