Skip to content

Added readthedocs support for deltacode - #140

Closed
ankit2001 wants to merge 1 commit into
aboutcode-org:developfrom
ankit2001:readthedocs
Closed

Added readthedocs support for deltacode#140
ankit2001 wants to merge 1 commit into
aboutcode-org:developfrom
ankit2001:readthedocs

Conversation

@ankit2001

Copy link
Copy Markdown

This pr is meant to solve issue #133 . I have moved the deltacode documentation to readthedocs ,now you can configure deltacode repo to deltacode.readthedocs.io.
Please review it @MaJuRG
Screenshot from 2020-03-14 23-13-01

@ankit2001

Copy link
Copy Markdown
Author

I also have #138 pr opened , please review both the pr @MaJuRG and sugest me changes

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankit2001 Before I can continue to review this, you need to address the following items:

  1. remove everything related to the docs virtualenv from this PR
  2. remove everything from the docs build directory from this PR

It seems like you have those added to the .gitignore file, but they are included in this PR for some and it is impossible to review at the moment.

Also, please rebase this branch into a single commit. Commit mesages such as "Updates" or "changes" are not helpful. It is much better to rebase into a single commit that has descriptive commit message

@ankit2001
ankit2001 force-pushed the readthedocs branch 4 times, most recently from 94746aa to a93ab8f Compare March 16, 2020 17:18
@ankit2001
ankit2001 requested a review from steven-esser March 16, 2020 17:20
@ankit2001

Copy link
Copy Markdown
Author

i have done the changes now u can review it @MaJuRG , i also added license.rst page ,if you do not need it , i can remove it.

@ankit2001
ankit2001 force-pushed the readthedocs branch 2 times, most recently from ca2c03a to f7eebb7 Compare March 17, 2020 05:00

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankit2001 Was the config + content take from the aboutcode repo? Just making sure here.

@ankit2001

Copy link
Copy Markdown
Author

Yeah @MaJuRG , just added license page also, i thought we need it , i can remove it if you want.

@ankit2001
ankit2001 requested a review from steven-esser March 18, 2020 04:29
@ankit2001
ankit2001 force-pushed the readthedocs branch 3 times, most recently from 37cd667 to f3c3e94 Compare March 18, 2020 13:41
Signed-off-by: ankit2001 <ankitchoudhary202.ac@gmail.com>

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the license.rst file

@steven-esser

Copy link
Copy Markdown
Contributor

Closing due to stagnation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants