Adding license expression - #142
pratik0316 wants to merge 2 commits into
Conversation
Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
…g a newline in the configure file Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
368b520 to
6acdbbf
Compare
|
@MaJuRG I added the license-expression library https://github.com/nexB/license-expression to DeltaCode , please review it. |
steven-esser
left a comment
steven-esser
left a comment
There was a problem hiding this comment.
Why are there many added whl files and this test__pyahocorasick.py?
| pytest-cov | ||
| codecov | ||
| pytest-rerunfailures | ||
| pluggy No newline at end of file |
There was a problem hiding this comment.
Why is this added here?
There was a problem hiding this comment.
@MaJuRG this was the extra requirements which was present in the License-expression Library,and regarding the .whl files it was present in the thirdparty folder of license expression library.I thaught these extra requirements and thirdparty .whl files would be required during configuration after adding license-expression library to the DeltaCode
There was a problem hiding this comment.
You would only need to add license_expression to the install_requires in setup.py.
The .whl files can be added to thirdparty, but these do not need to explicitly added to any requirements files
There was a problem hiding this comment.
Yes @MaJuRG ,it was my bad. Since .whl file of license_expression is already present in the thirdparty package it would be sufficient to add only license_expression in it install_requires in the setup.py
| from deltacode import __version__ | ||
| from deltacode.utils import deltas, get_notice, collect_errors | ||
|
|
||
|
|
There was a problem hiding this comment.
Why is this line removed?
2 participants
In this PR ,I added the License Expression Library to the DeltaCode.
Now when we activate the the virtual environment from the DeltaCode , we can have an access to the attributes and methods in the license expression library.
when we are doing source bin activate in the directory we can have access to the license code objects
This PR is addressing the issue #90 and #91