Add package url support for deltacode - #143
Closed
ankit2001 wants to merge 1 commit into
Closed
Conversation
Author
|
hey, @MaJuRG , i am adding package-url-support for deltacode so that we can further do differing on based of packages, can you please review and suggest me changes . |
ankit2001
force-pushed
the
package-url-support
branch
4 times, most recently
from
March 18, 2020 11:18
187d182 to
4cc93cb
Compare
Author
|
i have used the refrence https://github.com/package-url/packageurl-python |
Signed-off-by: ankit2001 <ankitchoudhary202.ac@gmail.com>
ankit2001
force-pushed
the
package-url-support
branch
from
March 18, 2020 13:15
4cc93cb to
fa97680
Compare
steven-esser
suggested changes
Mar 18, 2020
steven-esser
left a comment
steven-esser
left a comment
Contributor
There was a problem hiding this comment.
This is not how we want to add the packageurl library. We want to simply add the .whl file to the thirdparty/ directory.
Author
|
Sorry for misleading @MaJuRG , i will add it in new pr |
Author
|
i am closing this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.