Adding license expression - #144
Closed
pratik0316 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
pratik0316
force-pushed
the
addingLicense_Expression
branch
from
March 18, 2020 17:44
3094dd7 to
2e716ab
Compare
steven-esser
suggested changes
Mar 20, 2020
steven-esser
left a comment
steven-esser
left a comment
Contributor
There was a problem hiding this comment.
This is not enough.
We want to add the most up-to-date .whl file to thirdparty directory.
We also want to use the library in the code.
Collaborator
Author
|
Thanks @MaJuRG for the review . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the license_expression in the install_requires of the setup.py