Skip to content

added the windows build for travis CI having py2 interpreter - #152

Closed
pratik0316 wants to merge 1 commit into
aboutcode-org:developfrom
pratik0316:addingPy2Windows
Closed

added the windows build for travis CI having py2 interpreter#152
pratik0316 wants to merge 1 commit into
aboutcode-org:developfrom
pratik0316:addingPy2Windows

Conversation

@pratik0316

Copy link
Copy Markdown
Collaborator

added the windows build to travis CI having py2 as interpreter

Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
Comment thread .travis.yml
- os: windows
language: shell
before_install:
- choco install python2 -x86

@pratik0316 pratik0316 Apr 2, 2020

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

choco install python2 -x86 installs 32 bit libs in a 32 bit system.
without -x86 it installs 64 bit libs also which causes error during configuration.
ref

Comment thread .travis.yml
language: shell
before_install:
- choco install python2 -x86
- ln -s /c/Python27/python.exe /c/Python27/python2.7.exe

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to create a soft link pointing to /c/Python27/python.exe as during the configuration it will point to this executable file.

from deltacode import cli

options = add_windows_extra_timeout(options)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we do not have the support for adding the cli option --timeout, we may require it for the Appevyor windows CI as it timesout after 120 sec.

@pratik0316

Copy link
Copy Markdown
Collaborator Author

@MaJuRG the windows build is working.

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you reviewed how this is done for scancode-toolkit?

@pratik0316

Copy link
Copy Markdown
Collaborator Author

Have you reviewed how this is done for scancode-toolkit?

@MaJuRG scancode -toolkit is using osx and linux build in its TravisCi

@pratik0316

Copy link
Copy Markdown
Collaborator Author

Have you reviewed how this is done for scancode-toolkit?

@MaJuRG sorry I couldn't get you.
What do I need to be reviewed?

@pratik0316
pratik0316 requested a review from steven-esser April 2, 2020 16:26
@pratik0316

Copy link
Copy Markdown
Collaborator Author

@MaJuRG , should I need to make any additional changes in this windows build?

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we actually want windows builds in Travis CI. We probably want them in Appveryor like scancode-toolkit does.

@pratik0316

Copy link
Copy Markdown
Collaborator Author

@MaJuRG I will be adding the windows build for appveyor , I am closing this PR for now as it is not required , I will re - open it whenever needed

@pratik0316 pratik0316 closed this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants