[Test]VirtualCodebase - #166
Closed
pratik0316 wants to merge 9 commits into
Closed
Conversation
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
…ths asserts Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
pratik0316
commented
Mar 26, 2021
| self.new_files = [] # a list of [[new file1:Original path],[new file2:Original Path],...] | ||
| self.old_files = [] # a list of [[old file1:Original path],[old file2:Original Path],...] | ||
| self.new_files_fingerprint = dict() # map of { {new_file1:fingerprint},{new_file2:fingerprint},...} it will be needed when we need the fingerprints | ||
| self.old_files_fingerprint = dict() # map of { {old_file1:fingerprint},{old_file2:fingerprint},...} |
Collaborator
Author
There was a problem hiding this comment.
used for preserving the fingerprints in a way such that <file_location : figerprint> it is a dictionary
pratik0316
commented
Mar 26, 2021
| self.old_files_fingerprint = dict() # map of { {old_file1:fingerprint},{old_file2:fingerprint},...} | ||
| self.new_files_original_path = dict() #this keeps a map of the path of file with respect to original path | ||
| self.old_files_original_path = dict() | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
dictionary
to preserve the it is used later.
pratik0316
commented
Mar 26, 2021
|
|
||
| if self.codebase1 is not None and self.codebase2 is not None: | ||
| self.fetch_files(self.codebase1,self.new_files, self.new_files_fingerprint) | ||
| self.fetch_files(self.codebase2,self.old_files, self.old_files_fingerprint) |
Collaborator
Author
There was a problem hiding this comment.
Fetches old and new files
pratik0316
commented
Mar 26, 2021
| for i,obj in enumerate(resources): | ||
| files.append([obj,'']) | ||
| try : | ||
| fingerprint[obj.path] = obj.fingerprint |
Collaborator
Author
There was a problem hiding this comment.
stores the fingerprint which is used for similarity matchings
pratik0316
commented
Mar 26, 2021
| f[1] = f[0].path | ||
| for f in self.old_files: | ||
| f[1] = f[0].path | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
fix the path as the second value in self.new_files
pratik0316
commented
Mar 26, 2021
|
|
||
| def to_dict(self): | ||
| def copyrights_to_dict(self,file): | ||
| """ |
Collaborator
Author
There was a problem hiding this comment.
Copyright comparisons
pratik0316
commented
Mar 26, 2021
| else: | ||
| delta.update(0, category.lower() + ' added') | ||
| return | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
changes as per the new design
pratik0316
commented
Mar 26, 2021
| elif category not in unique_categories: | ||
| delta.update(0, category.lower() + ' added') | ||
|
|
||
| try: |
Collaborator
Author
There was a problem hiding this comment.
chages as per the new desing
pratik0316
commented
Mar 26, 2021
| ratio = (value / total) * 100 | ||
| return round(ratio, 2) | ||
| except ZeroDivisionError: | ||
| return 0 |
Collaborator
Author
There was a problem hiding this comment.
We need to handle this exception as total may be zero in cases where the codebase is not generated in case of invalid paths.
pratik0316
commented
Mar 26, 2021
|
|
||
| test_data_dir = os.path.join(os.path.dirname(__file__), 'data') | ||
|
|
||
| # TODO: need to fix in scancode |
Collaborator
Author
There was a problem hiding this comment.
cli/scan_1_file_moved_new.json is having fingerprint attribute so this test will fail as VirtualCodebase do not support fingerprint attribute
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com> fixed tests for test_deltacode.py Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
…ense_changes Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pratik Dey pratikrocks.dey11@gmail.com