Fix CI tests - #170
Merged
Merged
Conversation
The update in click library by 8d49e146ab8c2312e7917bb7c3f8abf01b8b55bf produces two artifacts in our codebase which caused the CI tests to fail 1) Capitalization of `N` in `No such option` 2) Wrapping `help` so as to break line on terminal width This is solved by using an arbitrarily large `TERMINAL_WIDTH=1000` Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Hritik14
force-pushed
the
develop
branch
4 times, most recently
from
July 7, 2021 21:56
9d1b038 to
1d0ba33
Compare
Hritik14
marked this pull request as draft
July 7, 2021 21:57
Hritik14
force-pushed
the
develop
branch
2 times, most recently
from
July 7, 2021 22:05
21039d9 to
5741d81
Compare
Windows doesn't allow changing the running executable. https://github.com/pypa/pip/issues/ 1299#issuecomment-27809600 It worked for so long because earlier pip versions provided by azure were already the latest ones and `--upgrade` did not modify the running pip. Now, suddenly a new pip was released which was not present in Azure windows and the `--upgrade pip` was triggered modifying the very executable it is running. Why does it say "Access is denied" (a permission error) is a mystery yet to be unrevealed by Microsoft folks. That said, untouched, this bug would have disappeared (when Azure updates the pip version) and reappeared again and again haunting us for long. No more. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
pratik0316
approved these changes
Jul 8, 2021
steven-esser
approved these changes
Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix click library pytest issues
The update in click library by 8d49e14 in pallets/click#1829 produces two artifacts in our codebase which caused the CI tests to fail
NinNo such optionhelpso as to break line on terminal width This is solved by using an arbitrarily largeTERMINAL_WIDTH=10002could be improved after pallets/click#1997Fix CI [WinError 5] Access is denied
Windows doesn't allow changing the running executable. pypa/pip#1299 (comment)
It worked for so long because earlier pip versions provided by azure
were already the latest ones and
--upgradedid not modify the runningpip. Now, suddenly a new pip was released which was not present in Azure
windows and the
--upgrade pipwas triggered modifying the veryexecutable it is running.
Why does it say "Access is denied" (a permission error) is a mystery yet
to be unrevealed by Microsoft folks.
That said, untouched, this bug would have disappeared (when Azure
updates the pip version) and reappeared again and again haunting us for
long. No more.
Signed-off-by: Hritik Vijay hritikxx8@gmail.com