Fix all broken tests and minor refactoring - #186
Merged
Conversation
arnav-mandal1234
requested review from
AyanSinhaMahapatra,
JonoYang and
pombredanne
March 21, 2023 11:53
arnav-mandal1234
force-pushed
the
test_fix
branch
2 times, most recently
from
March 21, 2023 18:09
712eb9a to
2687127
Compare
arnav-mandal1234
changed the title
* Add `type` field in the test JSONs. * Replace `get_resource_from_path` method with `get_resource` method. * Refactor `create_deltas` method signature - remove path parameters. Signed-off-by: Arnav Mandal <arnav.mandal1234@gmail.com>
arnav-mandal1234
force-pushed
the
test_fix
branch
from
March 21, 2023 18:35
2687127 to
c88b899
Compare
AyanSinhaMahapatra
approved these changes
Mar 21, 2023
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
Thanks! This looks good to me.
The failing tests are for two things IMHO:
- ubuntu_16/macos10_14/win_2016 is not supported anymore in azure piplines/github actions, so you get the
The remote provider was unable to process the requesterrors - all
python 3.6jobs are failing, probably due to some issue of python3.6 not being supported anymore.
This should go away after we merge skeleton into deltacode #182 as the azure-pipelines.yml is updated there with latest images and python versions.
We probably only want to support python 3.8+ as python 3.7 will also be deprecated soon, in ~3 months. Anyway we are merging deltacode in scancode-toolkit #183 so this isn't that important.
LGTM!
Member
|
@pombredanne ready for your review! |
pombredanne
approved these changes
Mar 21, 2023
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM!
I assume that the failing tests on the CI are because the skeleton is merged in another PR.
Collaborator
Author
|
@pombredanne yes, will update the skeleton in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all the broken tests. All the test cases are passing now.