Added config to run CI tests on travis - #11
Merged
Conversation
steven-esser
suggested changes
Mar 26, 2020
steven-esser
left a comment
steven-esser
left a comment
Contributor
There was a problem hiding this comment.
Have you tested this at all? Just wondering before I merge.
Contributor
Author
|
I did test it, it was on the `testing` branch, since my pull for
pkg-resources==0.0.0 wasn't merged by then the build failed on this branch.
I created the testing branch specifically to test with pull incorporated.
I don't have acces to my PC rn, I'll soon link the build log here for
quicker reference (it should be available in the commits for that branch)
…On Thu, 26 Mar, 2020, 23:57 Steven Esser, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Have you tested this at all? Just wondering before I merge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHXHK3YUP7YX73C2VAQPPQDRJONC5ANCNFSM4LD327UQ>
.
|
Contributor
Author
|
@MaJuRG Here's the build log for this config |
steven-esser
approved these changes
Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
What does this PR do?
I have added a
.travis.ymlconfig to run CI tests on travis.Implementation
I added python 3.5 to 3.8 builds for linux, as they come pre-configured with travis the implementation is rather simple, installing the requirements and running pytest to run tests.
With MacOS, travis provides no out of the box way to run python builds. The installation begins with installing pyenv through homebrew and loading the python from the version supplied in the
env. Test script is same as linux. After the script pyenv and homebrew folders are cached to cut the 5+ minute build time they take. Tests were configured for python 3.6 to 3.8.Notes
requirements.txt