Add tag support for rust packages - #16
Conversation
| return '{}/{}'.format(base_url, package) | ||
|
|
||
|
|
||
| def get_tags(package): |
There was a problem hiding this comment.
Shouldnt this be get_versions? AFAIK, tags are specific to git and other VCS systems.
There was a problem hiding this comment.
Yeah, you are right , will change it ASAP
|
@MaJuRG done |
steven-esser
left a comment
steven-esser
left a comment
There was a problem hiding this comment.
Can we get a few more tests here. Specifically when there is no/None data and when there is junk data?
We want to know what happens in these cases.
|
Yeah sure agreed, will add some testing :) |
|
@TG1999 at minimum we need to know the behavior of functions when they are passed Also, you can add some where there are special characters etc. You need to think about all the cases you may come across when using this code. |
|
Cool, thanks @MaJuRG for your guidance, will add the tests :D |
|
@MaJuRG all the changes have been addressed |
| if 'versions' in response: | ||
| versions = response.get('versions') |
There was a problem hiding this comment.
We can handle this a different way:
versions = response.get('versions', [])
This way, we can get rid of the "if" statement and one level of indentation. Some of your tests may need to be updated.
There was a problem hiding this comment.
Sure I will do the suggested updates
|
Done @MaJuRG |
Signed-off-by: TG1999 <tushar.goel.dav@gmail.com>
3 participants
Related issue #14
Signed-off-by: TG1999 tushar.goel.dav@gmail.com