Add VCS Support - #30
Conversation
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! I need to understand more about this PR. The commit messages are telling me nothing. And I think that you have carried in way too much details from pip. Can you explain what you did, which exact version you started from, etc?
| @@ -0,0 +1,15 @@ | |||
| # Expose a limited set of classes and functions so callers outside of | |||
There was a problem hiding this comment.
This should be a doctring for the module.
Take fork from pip https://github.com/pypa/pip/tree/20.1.1 Make a wrapper function to use VCS functionality from pip Signed-off-by: TG1999 <tushar.goel.dav@gmail.com>
steven-esser
left a comment
steven-esser
left a comment
There was a problem hiding this comment.
This looks like the right approach, testing-wise, unless I am missing something.
I think the only addition would be to add more mock tests like you have here to thoroughly test the VCS support of fetchcode.
|
Yeaah sure, I will add more tests now :) |
Signed-off-by: TG1999 <tushar.goel.dav@gmail.com>
steven-esser
left a comment
steven-esser
left a comment
There was a problem hiding this comment.
This looks good to me, though the diff is quite large.
@pombredanne anything to add here?
|
All good. Merging! |
3 participants
Signed-off-by: TG1999 tushar.goel.dav@gmail.com