Skip to content

Rst formatting issue fix #42 - #43

Merged
pombredanne merged 3 commits into
aboutcode-org:masterfrom
bobquest33:Issue-42
Oct 15, 2020
Merged

Rst formatting issue fix #42#43
pombredanne merged 3 commits into
aboutcode-org:masterfrom
bobquest33:Issue-42

Conversation

@bobquest33

Copy link
Copy Markdown
Contributor

Code format issues in rst has been fixed

@TG1999

TG1999 commented Oct 3, 2020

Copy link
Copy Markdown
Collaborator

Hi, thanks for this. Can you remove the line number 3 of Python code block, the location one :)

@bobquest33

Copy link
Copy Markdown
Contributor Author

Can you please share the exact code which you are highlighting, or add a comment in code changes part

@bobquest33 bobquest33 changed the title Fix Rst formatting issue Issue-#42 Fix Rst formatting issue#42 Oct 3, 2020
@bobquest33 bobquest33 changed the title Fix Rst formatting issue#42 Rst formatting issue fix#42 Oct 3, 2020
Comment thread README.rst Outdated
@bobquest33 bobquest33 changed the title Rst formatting issue fix#42 Rst formatting issue fix https://github.com/nexB#42 Oct 3, 2020
@bobquest33 bobquest33 changed the title Rst formatting issue fix https://github.com/nexB#42 Rst formatting issue fix #42 Oct 3, 2020
Comment thread README.rst Outdated
##################

To run test suite
`python3 -m pytest`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also make this line indented :) ?

Comment thread README.rst Outdated
@@ -12,22 +12,22 @@ Then install all the requirements using
`pip3 install -r requirements.txt`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also make this line indented :) ?

Comment thread README.rst
*********
It is a library to reliably fetch code via HTTP, FTP and version control systems.

Installation

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also make this line indented :) ? Line number 9 in Installation

@TG1999

TG1999 commented Oct 8, 2020

Copy link
Copy Markdown
Collaborator

Ping @bobquest33

Signed-off-by: TG1999 <tushar.goel.dav@gmail.com>
@TG1999

TG1999 commented Oct 14, 2020

Copy link
Copy Markdown
Collaborator

@pombredanne can you please have a look and merge this :)

Signed-off-by: TG1999 <tushar.goel.dav@gmail.com>
@pombredanne

Copy link
Copy Markdown
Member

@bobquest33 thanks!
Why do you remove test code though? that's completely unrelated to documentation.

@pombredanne

Copy link
Copy Markdown
Member

If something needs to be deleted, this should be in another PR IMHO and discussed there

@TG1999

TG1999 commented Oct 15, 2020

Copy link
Copy Markdown
Collaborator

Hi @pombredanne , I removed that, I told you earlier that we have some redundant code and some redundant tests were added for them, so removed them

@pombredanne

Copy link
Copy Markdown
Member

@TG1999 OK fair enough!
LGTM then 👍

@pombredanne
pombredanne merged commit ccb7b61 into aboutcode-org:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants