Skip to content

Add setup files, Author and Changelog - #46

Merged
pombredanne merged 1 commit into
aboutcode-org:masterfrom
TG1999:publish
Mar 30, 2021
Merged

Add setup files, Author and Changelog#46
pombredanne merged 1 commit into
aboutcode-org:masterfrom
TG1999:publish

Conversation

@TG1999

@TG1999 TG1999 commented Oct 27, 2020

Copy link
Copy Markdown
Collaborator

Signed-off-by: TG1999 tushar.goel.dav@gmail.com

@TG1999

TG1999 commented Oct 27, 2020

Copy link
Copy Markdown
Collaborator Author

@pombredanne wrt to aboutcode-org/scancode.io#35, please provide feedback over this

@TG1999 TG1999 changed the title Add setup file Add setup files, Author and Changelog Oct 28, 2020

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 This is looking good, see my few comments.

Comment thread setup.cfg
Comment thread setup.cfg Outdated
Comment on lines +28 to +31
attrs
packageurl-python
requests
six

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make these all 4-space indents?

Comment thread setup.cfg Outdated
Comment thread setup.cfg Outdated
Comment thread .travis.yml Outdated

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to my eye, however there is a Travis build failure here: https://travis-ci.org/github/nexB/fetchcode/builds/740005065

@TG1999

TG1999 commented Dec 7, 2020

Copy link
Copy Markdown
Collaborator Author

Hi @MaJuRG how can we resolve it? In earlier config all tests were passing, I can't understand why they are failing now, need some help on that

@steven-esser

Copy link
Copy Markdown
Contributor

To reiterate our conversation on https://gitter.im/aboutcode-org/discuss:

At first glance it looks like some import errors for some of the internal pip modules.

@sbs2001

sbs2001 commented Mar 18, 2021

Copy link
Copy Markdown

This is caused because pytest is collecting the files at https://github.com/TG1999/fetchcode/tree/publish/src/fetchcode/vcs/pip for running doctests. That probably casues some collisions with some internal pip modules .

One way to fix this would be to be explicit about test discovery. Essentially replacing

https://github.com/TG1999/fetchcode/blob/b95dd97f75c152cc2e9f88d61f16051bc765f3a7/.travis.yml#L17 to either
tmp/bin/pytest --ignore=src/fetchcode/vcs/pip or simply tmp/bin/pytest tests

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999

TG1999 commented Mar 18, 2021

Copy link
Copy Markdown
Collaborator Author

Thanks @sbs2001

@TG1999

TG1999 commented Mar 18, 2021

Copy link
Copy Markdown
Collaborator Author

Ping @MaJuRG @pombredanne

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 Looks good!

And thanks for the help @sbs2001

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Sorry for the belated review!

@pombredanne
pombredanne merged commit 42110e9 into aboutcode-org:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants