Add setup files, Author and Changelog - #46
Conversation
|
@pombredanne wrt to aboutcode-org/scancode.io#35, please provide feedback over this |
steven-esser
left a comment
There was a problem hiding this comment.
@TG1999 This is looking good, see my few comments.
steven-esser
left a comment
There was a problem hiding this comment.
This all looks good to my eye, however there is a Travis build failure here: https://travis-ci.org/github/nexB/fetchcode/builds/740005065
|
Hi @MaJuRG how can we resolve it? In earlier config all tests were passing, I can't understand why they are failing now, need some help on that |
|
To reiterate our conversation on https://gitter.im/aboutcode-org/discuss: At first glance it looks like some import errors for some of the internal pip modules. |
|
This is caused because pytest is collecting the files at https://github.com/TG1999/fetchcode/tree/publish/src/fetchcode/vcs/pip for running doctests. That probably casues some collisions with some internal pip modules . One way to fix this would be to be explicit about test discovery. Essentially replacing https://github.com/TG1999/fetchcode/blob/b95dd97f75c152cc2e9f88d61f16051bc765f3a7/.travis.yml#L17 to either |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
|
Thanks @sbs2001 |
|
Ping @MaJuRG @pombredanne |
pombredanne
left a comment
There was a problem hiding this comment.
Looking good!
Sorry for the belated review!
Signed-off-by: TG1999 tushar.goel.dav@gmail.com