Add basic docs - #16
Conversation
6069123 to
5d56307
Compare
steven-esser
left a comment
There was a problem hiding this comment.
@AyanSinhaMahapatra This looks good, just a few minor comments.
587e333 to
56d6e3e
Compare
Adds a RTD configuration file (v2) to customize builds. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
56d6e3e to
e7d1990
Compare
|
@MaJuRG I'm not sure why the RTD build is failing would you check - https://readthedocs.org/projects/ayan-fork-nexb-skeleton/builds/12558609/. The requirements install fine, local build also passes. Here are the docs I followed - https://docs.readthedocs.io/en/latest/config-file/v2.html#python |
steven-esser
left a comment
There was a problem hiding this comment.
@AyanSinhaMahapatra This looks good.
The error the RTD build returns is a problem. This is because a fresh clone of the skeleton repo does not contain a src/ directory that is usually present in an actual library (like extractcode
I think the best approach to solve this issue is to remove this line: https://github.com/nexB/skeleton/blob/ef210cd813de2961fe8ca4a5ec7f14532ea6e9f8/setup.cfg#L23
This will allow the ./configure script and the RTD CI system to run correctly. Once you remove that line and confirm, I will merge this.
|
Isn't that relevant for the package setup when the src is present? Like users still have to uncomment/use that line when they use the package right? This is the same error with which the Travis builds for skeleton is failing too. Would having a |
|
@AyanSinhaMahapatra Yes that is also a possible solution, though I would prefer to just have minimal README file that just says "put your python modules in this directory" instead of a dummy python file. |
|
@MaJuRG Yeah, that makes more sense. Do you want me to add a commit doing the same here? |
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
|
RTD build passes, CI tests fail because now even though |
|
@AyanSinhaMahapatra I do not really think it matters that the tests do not pass for this skeleton repo (as it is a template, not actual code). I have removed auto-builds in travis for now for this repo. |
Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com