Skip to content

Fix comparison in version subclasses - #106

Merged
TG1999 merged 3 commits into
aboutcode-org:mainfrom
TG1999:fix_comparison
Mar 21, 2023
Merged

Fix comparison in version subclasses#106
TG1999 merged 3 commits into
aboutcode-org:mainfrom
TG1999:fix_comparison

Conversation

@TG1999

@TG1999 TG1999 commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

fixes #105

@TG1999 TG1999 changed the title Fix comparison Fix comparison in version subclasses Mar 8, 2023
@TG1999
TG1999 force-pushed the fix_comparison branch 2 times, most recently from b1cc5de to 2cf099a Compare March 12, 2023 18:44
TG1999 added 2 commits March 13, 2023 18:37
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! please merge

@TG1999
TG1999 merged commit 5d7aff1 into aboutcode-org:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PypiVersion version comparison must behave like packaging Version

2 participants