Skip to content

Handle NoneType in VersionRange.from_string - #115

Merged
TG1999 merged 3 commits into
mainfrom
113-fix-versionrange
Aug 31, 2023
Merged

Handle NoneType in VersionRange.from_string#115
TG1999 merged 3 commits into
mainfrom
113-fix-versionrange

Conversation

@keshav-space

Copy link
Copy Markdown
Member

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
keshav-space requested a review from TG1999 August 29, 2023 21:11
Comment thread src/univers/version_range.py Outdated
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
keshav-space requested a review from TG1999 August 30, 2023 08:20
@TG1999

TG1999 commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

@keshav-space thanks, I think we should update the CI with the skeleton, some of these configurations are not supported any more.

@TG1999 TG1999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks++

@TG1999
TG1999 merged commit 0113d67 into main Aug 31, 2023
@keshav-space
keshav-space deleted the 113-fix-versionrange branch August 31, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throw ValueError when instantiating a VersionRange from None type

2 participants