Add tests to check from_string & from_spec equality - #28
Merged
Conversation
pombredanne
reviewed
Jan 14, 2022
pombredanne
reviewed
Jan 14, 2022
Hritik14
force-pushed
the
from_spec_native_test
branch
from
January 14, 2022 12:37
a71481c to
5fdf360
Compare
This will avoid errors like #27 popping up in future Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
This changes the logic: 1. we iterate explicitly on the tests. If a test is for a scheme that does not exist, it will fail 2. we also check that all schemes have a test and fail if not Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Hritik14
force-pushed
the
from_spec_native_test
branch
from
January 14, 2022 13:36
5fdf360 to
7fdc888
Compare
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Hritik14
force-pushed
the
from_spec_native_test
branch
from
January 14, 2022 13:42
7fdc888 to
3b9988d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will avoid errors like #27
popping up in future
Signed-off-by: Hritik Vijay hritikxx8@gmail.com