Fix for NpmVersionRange.from_native and README - #34
Merged
Conversation
keshav-space
changed the title
keshav-space
changed the title
pombredanne
requested changes
Feb 3, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Excellent catch!
Thanks... can you add a test or two?
Member
Author
Done !! |
Collaborator
|
@keshav-space codestyle tests are failing. Please run |
Hritik14
requested changes
Feb 13, 2022
Hritik14
left a comment
Hritik14
left a comment
Collaborator
There was a problem hiding this comment.
Really nice catch! I've added some suggestions for you to consider
Hritik14
requested changes
Feb 14, 2022
Hritik14
left a comment
Hritik14
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Just a few changes to go
Collaborator
|
@keshav-space LGTM! |
README: - Import `versions` instead of `version` - Use relative path to execute `configure` script version_range: - `NpmVersionRange.form_native` should generate tuple of `VersionConstraint` - Fixes: aboutcode-org#35 test_version_range: - Add test for NpmVersionRange.from_native Signed-off-by: keshav-space <keshav6240@gmail.com>
keshav-space
force-pushed
the
main
branch
2 times, most recently
from
February 15, 2022 13:25
1e46e46 to
fd9d341
Compare
- codestyle test for `etc`, will be handled by `skeleton` - see: aboutcode-org/skeleton#54 Signed-off-by: keshav-space <keshav6240@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Fix
READMEversionsinsteadversion2. Fix
NpmVersionRangeNpmVersionRange.from_native was returning a
tuplecontaininglist of VersionConstraintInstead it must return a
tuplecontainingVersionConstraintNpmVersionRange.from_native("^1.0.2")would returnconstraintsasFixes:
NpmVersionRange.from_nativeisn't returning constraints as intended #353. Add test for
NpmVersionRangetest_NpmVersionRange_from_native_with_compatible_with_version_operatortest_NpmVersionRange_from_native_with_approximately_equal_to_operator4. Don't do black codestyle test for
docsandetcetcto be handled byskeletonSigned-off-by: keshav-space keshav6240@gmail.com