add alpine support in univers - #39
Merged
Merged
Conversation
pombredanne
requested changes
Feb 15, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks! I have a few nitpickings for your review!
TG1999
force-pushed
the
alpine_linux
branch
2 times, most recently
from
February 16, 2022 13:28
759d46e to
fb9b487
Compare
TG1999
commented
Feb 16, 2022
TG1999
commented
Feb 16, 2022
TG1999
commented
Feb 16, 2022
Currently univers don't have a VersionClass for alpine linux, so add a version class for alpine linux and use same vercmp method that has been used by gentoo, avoid cases for now which have a leading 0 in them. Verify the current implementation of vercmp with the test data from here https://git.alpinelinux.org/apk-tools/tree/tests/version.data add ABOUT file and license for same Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
approved these changes
Feb 16, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
macOS is dead @Azure and we need to merge the latest skeleton, so ignore the failures.
This is looking great!
Thanks... merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com
closes issue #37