add native github ranges support - #49
Merged
pombredanne merged 1 commit intoMar 16, 2022
Merged
Conversation
TG1999
force-pushed
the
version_ranges/native_github
branch
8 times, most recently
from
March 16, 2022 13:28
5227a3d to
e717dd6
Compare
pombredanne
reviewed
Mar 16, 2022
| >>> vr = build_constraint_from_github_advisory_string("pypi","< 9.0") | ||
| >>> assert str(vr) == "<9.0", str(vr) | ||
| """ | ||
| vrc = RANGE_CLASS_BY_SCHEMES.get(scheme) |
Member
There was a problem hiding this comment.
IMHO we can be sure that scheme exists:
Suggested change
| vrc = RANGE_CLASS_BY_SCHEMES.get(scheme) | |
| vrc = RANGE_CLASS_BY_SCHEMES[scheme] |
TG1999
force-pushed
the
version_ranges/native_github
branch
2 times, most recently
from
March 16, 2022 13:38
0872494 to
984204a
Compare
TG1999
force-pushed
the
version_ranges/native_github
branch
from
March 16, 2022 13:40
984204a to
ac62daf
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
version_ranges/native_github
branch
from
March 16, 2022 13:42
ac62daf to
1ad6439
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com