Skip to content

Add version range support for maven #47 - #58

Merged
pombredanne merged 1 commit into
aboutcode-org:mainfrom
TG1999:maven/version_range
Apr 1, 2022
Merged

Add version range support for maven #47#58
pombredanne merged 1 commit into
aboutcode-org:mainfrom
TG1999:maven/version_range

Conversation

@TG1999

@TG1999 TG1999 commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! just a few nits
We should also test with multiple ranges like in affected_range: "[2.0,2.3.1],[2.4.0,2.12.2),[2.13.0,2.15.0)" from https://gitlab.com/gitlab-org/security-products/gemnasium-db/-/blob/master/maven/org.apache.logging.log4j/log4j-core/CVE-2021-44228.yml#L20

Comment thread src/univers/versions.py Outdated
Comment thread tests/test_maven_version_range.py Outdated
@TG1999
TG1999 force-pushed the maven/version_range branch from 7b4fca8 to c5ca4b6 Compare April 1, 2022 20:46
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999 force-pushed the maven/version_range branch from c5ca4b6 to ca517a1 Compare April 1, 2022 20:48

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 👍

@pombredanne
pombredanne merged commit e400e23 into aboutcode-org:main Apr 1, 2022
TG1999 pushed a commit to TG1999/univers that referenced this pull request May 10, 2022
Remove macos 10.14 job from azure-pipelines.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants