Skip to content

Test sorting of all the OpenSSL versions ever released - #61

Merged
pombredanne merged 2 commits into
aboutcode-org:mainfrom
keshav-space:test_openssl_sorting
May 4, 2022
Merged

Test sorting of all the OpenSSL versions ever released#61
pombredanne merged 2 commits into
aboutcode-org:mainfrom
keshav-space:test_openssl_sorting

Conversation

@keshav-space

Copy link
Copy Markdown
Member

@keshav-space
keshav-space force-pushed the test_openssl_sorting branch 4 times, most recently from 6b4d3e5 to 2dbb875 Compare April 19, 2022 11:56
@pombredanne
pombredanne requested a review from TG1999 April 26, 2022 13:07

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ... See a few nits for you consideration

Comment thread src/univers/versions.py Outdated
Comment thread src/univers/versions.py Outdated
Comment thread src/univers/versions.py Outdated
@keshav-space
keshav-space force-pushed the test_openssl_sorting branch 2 times, most recently from 78341a2 to f3cd077 Compare May 1, 2022 19:44
@keshav-space
keshav-space requested a review from pombredanne May 1, 2022 19:50

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... with a minor nitpicking

Comment thread src/univers/versions.py
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
- closes: aboutcode-org#46

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
keshav-space force-pushed the test_openssl_sorting branch from f3cd077 to 3eda1ed Compare May 3, 2022 10:39

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging!

@pombredanne
pombredanne merged commit 6badd8d into aboutcode-org:main May 4, 2022
@keshav-space
keshav-space deleted the test_openssl_sorting branch May 4, 2022 07:57
TG1999 pushed a commit to TG1999/univers that referenced this pull request May 10, 2022
Add usage instructions to README.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test the sorting of all the OpenSSL version ever released

2 participants