Add support for gitlab in pypi, npm, gem version ranges - #68
Merged
Conversation
TG1999
force-pushed
the
gitlab_version_ranges
branch
from
May 10, 2022 19:20
37fa346 to
0e79a2c
Compare
pombredanne
requested changes
May 10, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks ... see a few comments. BTW how di you assemble the test cases? They look great!
TG1999
force-pushed
the
gitlab_version_ranges
branch
from
May 11, 2022 11:32
0e79a2c to
ee6f0a9
Compare
Contributor
Author
@pombredanne I ran gitlab importer in VulnerableCode and logged the versions, that we were not able to parse That's awesome! I think we should have a few that were parsed alright too for good measure, |
pombredanne
requested changes
May 11, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thank you. Here are a few extra nits for your review.
TG1999
force-pushed
the
gitlab_version_ranges
branch
from
May 11, 2022 14:38
ee6f0a9 to
095b643
Compare
pombredanne
reviewed
May 12, 2022
pombredanne
reviewed
May 12, 2022
pombredanne
approved these changes
May 12, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates. Just a few nits left for your consideration and then please go ahead to merge and release!
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
gitlab_version_ranges
branch
from
May 12, 2022 09:17
095b643 to
9a460be
Compare
keshav-space
pushed a commit
that referenced
this pull request
Aug 30, 2023
Remove thirdparty and update ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com