Add composer and golang versions - #72
Merged
TG1999 merged 1 commit intoMay 13, 2022
Merged
Conversation
TG1999
force-pushed
the
version_ranges/composer_and_golang
branch
4 times, most recently
from
May 12, 2022 15:36
0f81bbf to
eb8d96b
Compare
pombredanne
reviewed
May 12, 2022
| VersionConstraint( | ||
| comparator=comparator, version=vrc.version_class(version_constraint) | ||
| ) | ||
| def from_gitlab_native(scheme, string): |
Member
There was a problem hiding this comment.
Is the scheme exactly that of GitLab? or this is ours and there has been a mapping already done upstream in VulnerableCode?
Contributor
Author
There was a problem hiding this comment.
This scheme is exactly from GitLab itself, the tests that I have added here are from GitLab only and not changed at all.
Member
There was a problem hiding this comment.
Good, so they use purl types like we do then! ... good.
Contributor
Author
There was a problem hiding this comment.
One thing, what do you mean by scheme here? The version range or the package type itself? We map the type from slug in yaml file to package url type, and then use as scheme here
pombredanne
approved these changes
May 12, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM! I just have one question.
pombredanne
approved these changes
May 12, 2022
TG1999
force-pushed
the
version_ranges/composer_and_golang
branch
from
May 13, 2022 11:15
eb8d96b to
657b0f7
Compare
And also support gitlab native ranges for them Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
version_ranges/composer_and_golang
branch
from
May 13, 2022 11:24
657b0f7 to
c80e716
Compare
keshav-space
pushed a commit
that referenced
this pull request
Aug 30, 2023
Add pycodestyle in setup.cfg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and also add support for their gitlab version ranges
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com