Fix Npm version range #79 - #82
Merged
Merged
Conversation
Reference: aboutcode-org#79 Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
fix_npm_version_range
branch
from
August 26, 2022 13:53
30e48e2 to
d3c8797
Compare
Contributor
Author
|
The test data is from https://github.com/nodejs/security-wg |
TG1999
force-pushed
the
fix_npm_version_range
branch
2 times, most recently
from
August 29, 2022 10:08
a23e252 to
97420ae
Compare
Reference: aboutcode-org#83 Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
fix_npm_version_range
branch
from
August 29, 2022 17:20
97420ae to
04ca2ed
Compare
pombredanne
requested changes
Sep 12, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks!
Here are a few comments for your consideration.
I think we need a few more explicit tests that validate that a native constraints ends up parsed in a proper expected VersionRange
pombredanne
reviewed
Sep 12, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Sorry ... test-wise I missed https://github.com/nexB/univers/pull/82/files#diff-58adb926ae29bae08bfc66394189fbf5204b81a6234f6f9428d15d5f2673b2fb ...!
So ignore the test comments.
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Contributor
Author
|
merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com