Improve code, doc and adopt latest skeleton - #9

Merged

pombredanne merged 187 commits into

mainfrom

Oct 30, 2021

pombredanne commented Oct 5, 2021 •

edited

Loading

Member

This PR:

adopts the latest https://github.com/nexB/skeleton
improves the provenance and license documentation
of third-party embedded code, including grafting the git history
when possible.
applies minor refactoring such as using a shared cmp()
backported function consistently, instead of the three variants
we had before.
adds new failing tests for RPM versions with carets Fix the rpm tests #2 and
improve RPM tests

pmatilai and others added 30 commits

November 21, 2008 23:29


          Add basic version comparison testing for install/upgrade

1524f58


          Add banners for nicer test output

b19736b


          Verify the various version comparison results in testsuite

82d1e73


          Move the current "version compare" tests to rpm install tests

4750ca0

- These are more about rpm install/upgrade behavior than pure
  version comparison, although obviously version comparison is involved


          Add bunch of rpmvercmp() algorithm tests to the test-suite

6296e37


          Switch the two remaining rpm runs under fakechroot

d5e8251

- Everything in the test-suite except rpmbuild execution is now
  performed in the fakechroot environment


          Add further version comparison test-cases

145c442

- Add pile of further tests for the more common constructs,
  collect various (old and new) corner cases from bugzilla.


          Add a few basic test-cases for tilde in version comparison

da565a8


          move pkgcore module to src directory

74822a3


          Skip tests using Lua iff Lua is disabled (#264)

e6a1464


          move tests to root dir

9f567e0


          more py3 conversions

39eb0be


          migrate tests to py3

bcc63ec


          various f-strings conversions

8eef024


          ebuild.cpv: simplify defining ver_cmp() in the cpy extension case

1a0c485


          tests/ebuild/test_cpv: update to use pytest

daac49e


          remove/fix old comments


          Add support for sorting caret ('^') higher than base version

42197aa

1.1^20160101 means 1.1 version (base) and patches which were applied at
that date on top of it.

* 1.1^201601 > 1.1
* 1.1^201601 < 1.1.1

Having symmetry is also good.

Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>


          misc f-string and consistency work

733a9d3


          ebuild.cpv: use better variable name for pkg category

2d987c4


          util.parserestrict: parse_match(): add support for globbed targets wi…

…th version restrictions

This lets you do things like: pclean pkg '>=*/alsa*-1.1.7'
which coincidentally removes all binpkgs for built alsa pkgs that break
audio output allowing one to then run:

pmerge -1dOKav alsa-lib alsa-plugins alsa-utils

which reinstalls the working 1.1.6 binpkgs of those pkgs.


          ebuild.cpv: store missing revisions internally as 0 instead of None

743c483

Except for unversioned objects.

Fixes #225.


          ebuild.cpv: store explicit -r0 revisions as 0 and missing as None

485fad3

Fixes MissingRevision check for pkgcheck.


          ebuild.cpv: store ebuild revisions as strings and compare as integers

14e2855

Fixes handling for leading '0' characters or using explicit '-r0'
revisioning.

Fixes #261.


          ebuild.cpv: make empty revision store an empty string

f37f5b3

And set revision to None only for non-versioned CPVs to match other
version attrs in that case.


          ebuild.cpv: _Revision: add __str__() to return '0' on missing revision

8e37025


          tests: move module unit tests into their own directory

395cdc0

To provide separation for future integration and benchmark tests in
relation to unit tests.


          package.errors: InvalidPackageName: split params into bad name and op…

45ac5f9

…tional msg


          remove license/copyright file headers

3d1c059

These are both covered by the LICENSE file in the repo's root directory.


          move to new snakeoil lazy module importing mechanism

fd02804

A few demandload-ed modules remain to explicitly break cyclical imports.
These might be removed with refactoring in the future.

pombredanne added 7 commits

October 15, 2021 15:15


          Handle as_text correctly in cache

255a898

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Merge origin/as_text-cache

7b76f4a

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Merge pull request #47 from nexB/as_text-cache

3a5307c

Handle as_text correctly in cache


          Add missing version constraint

af4a2ca

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Improve README

a46e34e

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Add black to test/devel utils

0b787d8

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Add support for Python 3.10

e5833d1

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Hritik14 mentioned this pull request

Separate import and improve operations aboutcode-org/vulnerablecode#525

Merged

9 tasks

pombredanne and others added 7 commits

October 29, 2021 17:37


          Adopt black style

0a0ef12

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Add code to use curl if wget is not installed

c8acebe

Signed-off-by: Chin Yeung Li <tli@nexb.com>


          Do not issue warning if thirdparty dir is missing

9f2b46a

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Handle as_text correctly in cache

f6c1d21

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Add support for Python 3.10

a118aa6

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Add missing dev requirements

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Merge latest skeleton

83fcb7b

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

pombredanne force-pushed the new-skeleton branch from c3d65e7 to 83fcb7b Compare

October 29, 2021 16:04

pombredanne added 6 commits

October 29, 2021 18:39


          Drop Ubuntu 16 add Python 3.10

31ed446

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Merge pull request #48 from nexB/update-system

00aaa26

Drop Ubuntu 16 add Python 3.10


          Merge remote-tracking branch 'skeleton/main' into new-skeleton

887cc76


          Use raw strings for regex

fcb402d

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Use explicit directories for style checks

1a01ec3

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Improve codestyle check

9d44053

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

pombredanne force-pushed the new-skeleton branch from 87c380c to 9d44053 Compare

October 29, 2021 17:11

pombredanne added 4 commits

October 29, 2021 19:17


          Disable Python 3.10 tests on macOS 10.14

2ce7c7a

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Merge pull request #49 from nexB/update-system

1fa3699

Disable Python 3.10 tests on macOS 10.14


          Merge remote-tracking branch 'skeleton/main' into new-skeleton

6bfc5c4


          Use lowercase for univers library name

92c9db1

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

pombredanne commented Oct 29, 2021

Member Author

This is all green at last!

pombredanne merged commit 12ebed2 into main

pombredanne deleted the new-skeleton branch

October 30, 2021 08:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet