Skip to content

Fix : GemVersion TypeError unhashable type: 'list' #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TG1999 merged 3 commits into from
Feb 10, 2023
Merged

Fix : GemVersion TypeError unhashable type: 'list' #98

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e4dfee
Fix : GemVersion TypeError unhashable type: 'list'
ziadhany Feb 7, 2023
1794018
Test that GemVersion is hashable
pombredanne Feb 10, 2023
bf190c1
Fix formatting tests
TG1999 Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/univers/gem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def equal_strictly(self, other):
return self.version == other.version

def __hash__(self):
return hash(self.canonical_segments)
return hash(tuple(self.canonical_segments))

def __eq__(self, other):
return self.canonical_segments == other.canonical_segments
Expand Down Expand Up @@ -321,7 +321,7 @@ def get_segments(self):
def canonical_segments(self):
if not self._canonical_segments:
self._canonical_segments = self.get_canonical_segments()
return list(self._canonical_segments)
return tuple(self._canonical_segments)

def get_canonical_segments(self):
"""
Expand Down
6 changes: 3 additions & 3 deletions tests/test_rubygems_gem_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,9 @@ def test_split_segments():


def test_canonical_segments():
assert GemVersion("1.0.0").canonical_segments == [1]
assert GemVersion("1.0.0.a.1.0").canonical_segments == [1, "a", 1]
assert GemVersion("1.2.3-1").canonical_segments == [1, 2, 3, "pre", 1]
assert GemVersion("1.0.0").canonical_segments == (1,)
assert GemVersion("1.0.0.a.1.0").canonical_segments == (1, "a", 1)
assert GemVersion("1.2.3-1").canonical_segments == (1, 2, 3, "pre", 1)
Comment thread
pombredanne marked this conversation as resolved.


def test_frozen_version():
Expand Down