Skip to content

Use SemverVersion in NginxVersionRange - #27

Merged
Hritik14 merged 1 commit into
mainfrom
fix/to_from_spec
Jan 14, 2022
Merged

Use SemverVersion in NginxVersionRange#27
Hritik14 merged 1 commit into
mainfrom
fix/to_from_spec

Conversation

@Hritik14

Copy link
Copy Markdown
Collaborator

Fixes: #24

Signed-off-by: Hritik Vijay hritikxx8@gmail.com

Hritik14 added a commit that referenced this pull request Jan 13, 2022
This will avoid errors like #27
popping up in future

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixes: #24

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
@Hritik14
Hritik14 merged commit 4dccdfb into main Jan 14, 2022
@Hritik14
Hritik14 deleted the fix/to_from_spec branch January 14, 2022 07:30
Hritik14 added a commit that referenced this pull request Jan 14, 2022
This will avoid errors like #27
popping up in future

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Hritik14 added a commit that referenced this pull request Jan 14, 2022
This will avoid errors like #27
popping up in future

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NginxVersionRange from_native and from_string generating different VersionRange

2 participants